[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/7] pseries NUMA distance rework
From: |
David Gibson |
Subject: |
Re: [PATCH v2 0/7] pseries NUMA distance rework |
Date: |
Thu, 3 Sep 2020 11:49:04 +1000 |
On Thu, Sep 03, 2020 at 11:35:39AM +1000, David Gibson wrote:
> On Tue, Sep 01, 2020 at 09:56:38AM -0300, Daniel Henrique Barboza wrote:
> > Hi,
> >
> > Following the reviews of the first version [1], specially this
> > reply from David [2], I decided to take a step back and refactor
> > all the code in hw/ppc/spapr* that operates with ibm,associativity,
> > ibm,associativity-reference-points and ibm,max-associativity-domains.
> >
> > A new file named 'spapr_numa.c' was created to gather all the
> > associativity related code into helpers that write NUMA/associativity
> > related info to the FDT. These helpers are then used in other
> > spapr_* files. This allows us to change NUMA related code in a
> > single location, instead of searching every file to see where is
> > associativity being written and how, and all the soon to get
> > more complex logic can be contained in spapr_numa.c. I consider
> > the end result to be better than what I ended up doing in v1.
> >
> > Unlike v1, there is no NUMA distance change being done in this series.
> > Later on, the hub of the new NUMA distance calculation will be
> > spapr_numa_associativity_init(), where we'll take into consideration
> > user input from numa_states, handle sizes to what the PAPR kernel
> > understands and establish assoaciativity domains between the NUMA
> > nodes.
>
> Patches 1..4 applied to ppc-for-5.2. Patch 5 has some nits I've
> commented on.
Ah, sorry, I realised I missed something. Patches 1..2 are still
applied, but patch 3 has a nit large enough to call for a respin.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [PATCH v2 5/7] spapr, spapr_numa: move lookup-arrays handling to spapr_numa.c, (continued)
- [PATCH v2 1/7] ppc: introducing spapr_numa.c NUMA code helper, Daniel Henrique Barboza, 2020/09/01
- [PATCH v2 4/7] spapr, spapr_numa: handle vcpu ibm,associativity, Daniel Henrique Barboza, 2020/09/01
- [PATCH v2 6/7] spapr_numa: move NVLink2 associativity handling to spapr_numa.c, Daniel Henrique Barboza, 2020/09/01
- [PATCH v2 7/7] spapr_hcall: h_home_node_associativity now reads numa_assoc_array, Daniel Henrique Barboza, 2020/09/01
- Re: [PATCH v2 0/7] pseries NUMA distance rework, David Gibson, 2020/09/02
- Re: [PATCH v2 0/7] pseries NUMA distance rework,
David Gibson <=