[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] spapr_numa: forbid asymmetrical NUMA setups
From: |
Greg Kurz |
Subject: |
Re: [PATCH 2/6] spapr_numa: forbid asymmetrical NUMA setups |
Date: |
Thu, 24 Sep 2020 10:01:06 +0200 |
On Wed, 23 Sep 2020 16:34:54 -0300
Daniel Henrique Barboza <danielhb413@gmail.com> wrote:
> The pSeries machine does not support asymmetrical NUMA
> configurations. This doesn't make much of a different
> since we're not using user input for pSeries NUMA setup,
> but this will change in the next patches.
>
> To avoid breaking existing setups, gate this change by
> checking for legacy NUMA support.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---
> hw/ppc/spapr_numa.c | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/hw/ppc/spapr_numa.c b/hw/ppc/spapr_numa.c
> index 64fe567f5d..36aaa273ee 100644
> --- a/hw/ppc/spapr_numa.c
> +++ b/hw/ppc/spapr_numa.c
> @@ -19,6 +19,24 @@
> /* Moved from hw/ppc/spapr_pci_nvlink2.c */
> #define SPAPR_GPU_NUMA_ID (cpu_to_be32(1))
>
> +static bool spapr_numa_is_symmetrical(MachineState *ms)
> +{
> + int src, dst;
> + int nb_numa_nodes = ms->numa_state->num_nodes;
> + NodeInfo *numa_info = ms->numa_state->nodes;
> +
> + for (src = 0; src < nb_numa_nodes; src++) {
> + for (dst = src; dst < nb_numa_nodes; dst++) {
> + if (numa_info[src].distance[dst] !=
> + numa_info[dst].distance[src]) {
> + return false;
> + }
> + }
> + }
> +
> + return true;
> +}
> +
> void spapr_numa_associativity_init(SpaprMachineState *spapr,
> MachineState *machine)
> {
> @@ -61,6 +79,22 @@ void spapr_numa_associativity_init(SpaprMachineState
> *spapr,
>
> spapr->numa_assoc_array[i][MAX_DISTANCE_REF_POINTS] = cpu_to_be32(i);
> }
> +
> + /*
> + * Legacy NUMA guests (pseries-5.1 and order, or guests with only
s/order/older
> + * 1 NUMA node) will not benefit from anything we're going to do
> + * after this point.
> + */
> + if (spapr_machine_using_legacy_numa(spapr)) {
> + return;
> + }
> +
> + if (!spapr_numa_is_symmetrical(machine)) {
> + error_report("Asymmetrical NUMA topologies aren't supported "
> + "in the pSeries machine");
> + exit(1);
Even if the code base is still heavily populated with exit(1), it seems
that exit(EXIT_FAILURE) is preferred.
Anyway,
Reviewed-by: Greg Kurz <groug@kaod.org>
> + }
> +
> }
>
> void spapr_numa_write_associativity_dt(SpaprMachineState *spapr, void *fdt,
- [PATCH 0/6] pseries NUMA distance calculation, Daniel Henrique Barboza, 2020/09/23
- [PATCH 1/6] spapr: add spapr_machine_using_legacy_numa() helper, Daniel Henrique Barboza, 2020/09/23
- [PATCH 2/6] spapr_numa: forbid asymmetrical NUMA setups, Daniel Henrique Barboza, 2020/09/23
- Re: [PATCH 2/6] spapr_numa: forbid asymmetrical NUMA setups,
Greg Kurz <=
- [PATCH 4/6] spapr_numa: change reference-points and maxdomain settings, Daniel Henrique Barboza, 2020/09/23
- [PATCH 3/6] spapr_numa: translate regular NUMA distance to PAPR distance, Daniel Henrique Barboza, 2020/09/23
- [PATCH 5/6] spapr_numa: consider user input when defining associativity, Daniel Henrique Barboza, 2020/09/23