[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs
From: |
David Gibson |
Subject: |
Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs |
Date: |
Sat, 17 Oct 2020 17:20:00 +1100 |
On Fri, Oct 16, 2020 at 07:53:10AM +0100, Mark Cave-Ayland wrote:
> On 16/10/2020 07:45, Howard Spoelstra wrote:
>
> > Hi,
> >
> > I see compilation of the current ppc-for-5.2 branch fail with:
> >
> > ../hw/pci-host/grackle.c: In function ‘grackle_realize’:
> > ../hw/pci-host/grackle.c:68:11: error: ‘GrackleState’ has no member named
> > ‘pic’
> > 68 | if (!s->pic) {
> > | ^~
> > make: *** [Makefile.ninja:1741: libcommon.fa.p/hw_pci-host_grackle.c.o]
> > Error 1
> >
> > Best,
> > Howard
>
> I see - as per the cover letter, my series is a replacement for Phil's
> original patch at
> https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02988.html (the PIC
> link is now completely removed), so the solution here is to drop patch
> 7daac97 "hw/pci-host/grackle: Verify PIC link is properly set".
Ok, I've removed that from my ppc-for-5.2 tree.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs, (continued)
- [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs, Mark Cave-Ayland, 2020/10/13
- Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs, Philippe Mathieu-Daudé, 2020/10/13
- Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs, Mark Cave-Ayland, 2020/10/13
- Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs, BALATON Zoltan, 2020/10/13
- Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs, Mark Cave-Ayland, 2020/10/15
- Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs, BALATON Zoltan, 2020/10/15
- Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs, Mark Cave-Ayland, 2020/10/17
Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs, David Gibson, 2020/10/15
[PATCH v2 3/3] uninorth: use qdev gpios for PCI IRQs, Mark Cave-Ayland, 2020/10/13
Re: [PATCH v2 3/3] uninorth: use qdev gpios for PCI IRQs, Philippe Mathieu-Daudé, 2020/10/13
Re: [PATCH v2 3/3] uninorth: use qdev gpios for PCI IRQs, David Gibson, 2020/10/15