[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xive: Add trace events
|
From: |
David Gibson |
|
Subject: |
Re: [PATCH] xive: Add trace events |
|
Date: |
Tue, 24 Nov 2020 12:47:58 +1100 |
On Mon, Nov 23, 2020 at 05:37:17PM +0100, Cédric Le Goater wrote:
> I have been keeping those logging messages in an ugly form for
> while. Make them clean !
>
> Beware not to activate all of them, this is really verbose.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied to ppc-for-6.0, thanks.
> ---
> hw/intc/spapr_xive.c | 27 +++++++++++++++++++++++++++
> hw/intc/xive.c | 40 +++++++++++++++++++++++++++++++++++++---
> hw/intc/trace-events | 26 ++++++++++++++++++++++++++
> 3 files changed, 90 insertions(+), 3 deletions(-)
>
> diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c
> index 1fa09f287ac0..644cc85cbdc9 100644
> --- a/hw/intc/spapr_xive.c
> +++ b/hw/intc/spapr_xive.c
> @@ -24,6 +24,7 @@
> #include "hw/ppc/xive.h"
> #include "hw/ppc/xive_regs.h"
> #include "hw/qdev-properties.h"
> +#include "trace.h"
>
> /*
> * XIVE Virtualization Controller BAR and Thread Managment BAR that we
> @@ -900,6 +901,8 @@ static target_ulong h_int_get_source_info(PowerPCCPU *cpu,
> target_ulong flags = args[0];
> target_ulong lisn = args[1];
>
> + trace_spapr_xive_get_source_info(flags, lisn);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1015,6 +1018,8 @@ static target_ulong h_int_set_source_config(PowerPCCPU
> *cpu,
> uint8_t end_blk;
> uint32_t end_idx;
>
> + trace_spapr_xive_set_source_config(flags, lisn, target, priority, eisn);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1120,6 +1125,8 @@ static target_ulong h_int_get_source_config(PowerPCCPU
> *cpu,
> uint8_t nvt_blk;
> uint32_t end_idx, nvt_idx;
>
> + trace_spapr_xive_get_source_config(flags, lisn);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1194,6 +1201,8 @@ static target_ulong h_int_get_queue_info(PowerPCCPU
> *cpu,
> uint8_t end_blk;
> uint32_t end_idx;
>
> + trace_spapr_xive_get_queue_info(flags, target, priority);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1281,6 +1290,8 @@ static target_ulong h_int_set_queue_config(PowerPCCPU
> *cpu,
> uint8_t end_blk, nvt_blk;
> uint32_t end_idx, nvt_idx;
>
> + trace_spapr_xive_set_queue_config(flags, target, priority, qpage, qsize);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1448,6 +1459,8 @@ static target_ulong h_int_get_queue_config(PowerPCCPU
> *cpu,
> uint8_t end_blk;
> uint32_t end_idx;
>
> + trace_spapr_xive_get_queue_config(flags, target, priority);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1541,6 +1554,10 @@ static target_ulong
> h_int_set_os_reporting_line(PowerPCCPU *cpu,
> target_ulong opcode,
> target_ulong *args)
> {
> + target_ulong flags = args[0];
> +
> + trace_spapr_xive_set_os_reporting_line(flags);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1577,6 +1594,10 @@ static target_ulong
> h_int_get_os_reporting_line(PowerPCCPU *cpu,
> target_ulong opcode,
> target_ulong *args)
> {
> + target_ulong flags = args[0];
> +
> + trace_spapr_xive_get_os_reporting_line(flags);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1629,6 +1650,8 @@ static target_ulong h_int_esb(PowerPCCPU *cpu,
> hwaddr mmio_addr;
> XiveSource *xsrc = &xive->source;
>
> + trace_spapr_xive_esb(flags, lisn, offset, data);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1698,6 +1721,8 @@ static target_ulong h_int_sync(PowerPCCPU *cpu,
> target_ulong flags = args[0];
> target_ulong lisn = args[1];
>
> + trace_spapr_xive_sync(flags, lisn);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> @@ -1763,6 +1788,8 @@ static target_ulong h_int_reset(PowerPCCPU *cpu,
> SpaprXive *xive = spapr->xive;
> target_ulong flags = args[0];
>
> + trace_spapr_xive_reset(flags);
> +
> if (!spapr_ovec_test(spapr->ov5_cas, OV5_XIVE_EXPLOIT)) {
> return H_FUNCTION;
> }
> diff --git a/hw/intc/xive.c b/hw/intc/xive.c
> index 489e6256ef70..fa8c3d82877f 100644
> --- a/hw/intc/xive.c
> +++ b/hw/intc/xive.c
> @@ -21,6 +21,7 @@
> #include "hw/irq.h"
> #include "hw/ppc/xive.h"
> #include "hw/ppc/xive_regs.h"
> +#include "trace.h"
>
> /*
> * XIVE Thread Interrupt Management context
> @@ -93,6 +94,10 @@ static uint64_t xive_tctx_accept(XiveTCTX *tctx, uint8_t
> ring)
>
> /* Drop Exception bit */
> regs[TM_NSR] &= ~mask;
> +
> + trace_xive_tctx_accept(tctx->cs->cpu_index, ring,
> + regs[TM_IPB], regs[TM_PIPR],
> + regs[TM_CPPR], regs[TM_NSR]);
> }
>
> return (nsr << 8) | regs[TM_CPPR];
> @@ -113,12 +118,21 @@ static void xive_tctx_notify(XiveTCTX *tctx, uint8_t
> ring)
> default:
> g_assert_not_reached();
> }
> + trace_xive_tctx_notify(tctx->cs->cpu_index, ring,
> + regs[TM_IPB], regs[TM_PIPR],
> + regs[TM_CPPR], regs[TM_NSR]);
> qemu_irq_raise(xive_tctx_output(tctx, ring));
> }
> }
>
> static void xive_tctx_set_cppr(XiveTCTX *tctx, uint8_t ring, uint8_t cppr)
> {
> + uint8_t *regs = &tctx->regs[ring];
> +
> + trace_xive_tctx_set_cppr(tctx->cs->cpu_index, ring,
> + regs[TM_IPB], regs[TM_PIPR],
> + cppr, regs[TM_NSR]);
> +
> if (cppr > XIVE_PRIORITY_MAX) {
> cppr = 0xff;
> }
> @@ -508,6 +522,8 @@ void xive_tctx_tm_write(XivePresenter *xptr, XiveTCTX
> *tctx, hwaddr offset,
> {
> const XiveTmOp *xto;
>
> + trace_xive_tctx_tm_write(offset, size, value);
> +
> /*
> * TODO: check V bit in Q[0-3]W2
> */
> @@ -545,6 +561,7 @@ uint64_t xive_tctx_tm_read(XivePresenter *xptr, XiveTCTX
> *tctx, hwaddr offset,
> unsigned size)
> {
> const XiveTmOp *xto;
> + uint64_t ret;
>
> /*
> * TODO: check V bit in Q[0-3]W2
> @@ -560,7 +577,8 @@ uint64_t xive_tctx_tm_read(XivePresenter *xptr, XiveTCTX
> *tctx, hwaddr offset,
> "@%"HWADDR_PRIx"\n", offset);
> return -1;
> }
> - return xto->read_handler(xptr, tctx, offset, size);
> + ret = xto->read_handler(xptr, tctx, offset, size);
> + goto out;
> }
>
> /*
> @@ -568,13 +586,17 @@ uint64_t xive_tctx_tm_read(XivePresenter *xptr,
> XiveTCTX *tctx, hwaddr offset,
> */
> xto = xive_tm_find_op(offset, size, false);
> if (xto) {
> - return xto->read_handler(xptr, tctx, offset, size);
> + ret = xto->read_handler(xptr, tctx, offset, size);
> + goto out;
> }
>
> /*
> * Finish with raw access to the register values
> */
> - return xive_tm_raw_read(tctx, offset, size);
> + ret = xive_tm_raw_read(tctx, offset, size);
> +out:
> + trace_xive_tctx_tm_read(offset, size, ret);
> + return ret;
> }
>
> static char *xive_tctx_ring_print(uint8_t *ring)
> @@ -1005,6 +1027,8 @@ static uint64_t xive_source_esb_read(void *opaque,
> hwaddr addr, unsigned size)
> offset);
> }
>
> + trace_xive_source_esb_read(addr, srcno, ret);
> +
> return ret;
> }
>
> @@ -1030,6 +1054,8 @@ static void xive_source_esb_write(void *opaque, hwaddr
> addr,
> uint32_t srcno = addr >> xsrc->esb_shift;
> bool notify = false;
>
> + trace_xive_source_esb_write(addr, srcno, value);
> +
> /* In a two pages ESB MMIO setting, trigger page only triggers */
> if (xive_source_is_trigger_page(xsrc, addr)) {
> notify = xive_source_esb_trigger(xsrc, srcno);
> @@ -1507,6 +1533,7 @@ static bool xive_presenter_notify(XiveFabric *xfb,
> uint8_t format,
>
> /* handle CPU exception delivery */
> if (count) {
> + trace_xive_presenter_notify(nvt_blk, nvt_idx, match.ring);
> xive_tctx_ipb_update(match.tctx, match.ring,
> priority_to_ipb(priority));
> }
>
> @@ -1558,6 +1585,7 @@ static void xive_router_end_notify(XiveRouter *xrtr,
> uint8_t end_blk,
> }
>
> if (!xive_end_is_valid(&end)) {
> + trace_xive_router_end_notify(end_blk, end_idx, end_data);
> qemu_log_mask(LOG_GUEST_ERROR, "XIVE: END %x/%x is invalid\n",
> end_blk, end_idx);
> return;
> @@ -1683,6 +1711,10 @@ do_escalation:
> }
> }
>
> + trace_xive_router_end_escalate(end_blk, end_idx,
> + (uint8_t) xive_get_field32(END_W4_ESC_END_BLOCK, end.w4),
> + (uint32_t) xive_get_field32(END_W4_ESC_END_INDEX, end.w4),
> + (uint32_t) xive_get_field32(END_W5_ESC_END_DATA, end.w5));
> /*
> * The END trigger becomes an Escalation trigger
> */
> @@ -1796,6 +1828,8 @@ static uint64_t xive_end_source_read(void *opaque,
> hwaddr addr, unsigned size)
> end_blk = xive_router_get_block_id(xsrc->xrtr);
> end_idx = addr >> (xsrc->esb_shift + 1);
>
> + trace_xive_end_source_read(end_blk, end_idx, addr);
> +
> if (xive_router_get_end(xsrc->xrtr, end_blk, end_idx, &end)) {
> qemu_log_mask(LOG_GUEST_ERROR, "XIVE: No END %x/%x\n", end_blk,
> end_idx);
> diff --git a/hw/intc/trace-events b/hw/intc/trace-events
> index 22782b3f089b..77addc100f72 100644
> --- a/hw/intc/trace-events
> +++ b/hw/intc/trace-events
> @@ -203,3 +203,29 @@ heathrow_set_irq(int num, int level) "set_irq:
> num=0x%02x level=%d"
> # bcm2835_ic.c
> bcm2835_ic_set_gpu_irq(int irq, int level) "GPU irq #%d level %d"
> bcm2835_ic_set_cpu_irq(int irq, int level) "CPU irq #%d level %d"
> +
> +# spapr_xive.c
> +spapr_xive_get_source_info(uint64_t flags, uint64_t lisn) "flags=0x%"PRIx64"
> lisn=0x%"PRIx64
> +spapr_xive_set_source_config(uint64_t flags, uint64_t lisn, uint64_t target,
> uint64_t priority, uint64_t eisn) "flags=0x%"PRIx64" lisn=0x%"PRIx64"
> target=0x%"PRIx64" priority=0x%"PRIx64" eisn=0x%"PRIx64
> +spapr_xive_get_source_config(uint64_t flags, uint64_t lisn)
> "flags=0x%"PRIx64" lisn=0x%"PRIx64
> +spapr_xive_get_queue_info(uint64_t flags, uint64_t target, uint64_t
> priority) "flags=0x%"PRIx64" target=0x%"PRIx64" priority=0x%"PRIx64
> +spapr_xive_set_queue_config(uint64_t flags, uint64_t target, uint64_t
> priority, uint64_t qpage, uint64_t qsize) "flags=0x%"PRIx64"
> target=0x%"PRIx64" priority=0x%"PRIx64" qpage=0x%"PRIx64" qsize=0x%"PRIx64
> +spapr_xive_get_queue_config(uint64_t flags, uint64_t target, uint64_t
> priority) "flags=0x%"PRIx64" target=0x%"PRIx64" priority=0x%"PRIx64
> +spapr_xive_set_os_reporting_line(uint64_t flags) "flags=0x%"PRIx64
> +spapr_xive_get_os_reporting_line(uint64_t flags) "flags=0x%"PRIx64
> +spapr_xive_esb(uint64_t flags, uint64_t lisn, uint64_t offset, uint64_t
> data) "flags=0x%"PRIx64" lisn=0x%"PRIx64" offset=0x%"PRIx64" data=0x%"PRIx64
> +spapr_xive_sync(uint64_t flags, uint64_t lisn) "flags=0x%"PRIx64"
> lisn=0x%"PRIx64
> +spapr_xive_reset(uint64_t flags) "flags=0x%"PRIx64
> +
> +# xive.c
> +xive_tctx_accept(uint32_t index, uint8_t ring, uint8_t ipb, uint8_t pipr,
> uint8_t cppr, uint8_t nsr) "target=%d ring=0x%x IBP=0x%02x PIPR=0x%02x
> CPPR=0x%02x NSR=0x%02x ACK"
> +xive_tctx_notify(uint32_t index, uint8_t ring, uint8_t ipb, uint8_t pipr,
> uint8_t cppr, uint8_t nsr) "target=%d ring=0x%x IBP=0x%02x PIPR=0x%02x
> CPPR=0x%02x NSR=0x%02x raise !"
> +xive_tctx_set_cppr(uint32_t index, uint8_t ring, uint8_t ipb, uint8_t pipr,
> uint8_t cppr, uint8_t nsr) "target=%d ring=0x%x IBP=0x%02x PIPR=0x%02x new
> CPPR=0x%02x NSR=0x%02x"
> +xive_source_esb_read(uint64_t addr, uint32_t srcno, uint64_t value)
> "@0x0x%"PRIx64" IRQ 0x%x val=0x0x%"PRIx64
> +xive_source_esb_write(uint64_t addr, uint32_t srcno, uint64_t value)
> "@0x0x%"PRIx64" IRQ 0x%x val=0x0x%"PRIx64
> +xive_router_end_notify(uint8_t end_blk, uint32_t end_idx, uint32_t end_data)
> "END 0x%02x/0x%04x -> enqueue 0x%08x"
> +xive_router_end_escalate(uint8_t end_blk, uint32_t end_idx, uint8_t esc_blk,
> uint32_t esc_idx, uint32_t end_data) "END 0x%02x/0x%04x -> escalate END
> 0x%02x/0x%04x data 0x%08x"
> +xive_tctx_tm_write(uint64_t offset, unsigned int size, uint64_t value)
> "@0x0x%"PRIx64" sz=%d val=0x%" PRIx64
> +xive_tctx_tm_read(uint64_t offset, unsigned int size, uint64_t value)
> "@0x0x%"PRIx64" sz=%d val=0x%" PRIx64
> +xive_presenter_notify(uint8_t nvt_blk, uint32_t nvt_idx, uint8_t ring)
> "found NVT 0x%x/0x%x ring=0x%x"
> +xive_end_source_read(uint8_t end_blk, uint32_t end_idx, uint64_t addr) "END
> 0x%x/0x%x @0x0x%"PRIx64
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature