[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 28/28] checkpatch: Do not allow deprecated g_memdup()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 28/28] checkpatch: Do not allow deprecated g_memdup() |
Date: |
Fri, 3 Sep 2021 19:45:10 +0200 |
g_memdup() is insecure and as been deprecated in GLib 2.68.
QEMU provides the safely equivalent g_memdup2() wrapper.
Do not allow more g_memdup() calls in the repository, provide
a hint to use g_memdup2().
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
scripts/checkpatch.pl | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index cb8eff233e0..5caa739db48 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2850,6 +2850,11 @@ sub process {
WARN("consider using g_path_get_$1() in preference to
g_strdup($1())\n" . $herecurr);
}
+# enforce g_memdup2() over g_memdup()
+ if ($line =~ /\bg_memdup\s*\(/) {
+ ERROR("use g_memdup2() instead of unsafe g_memdup()\n"
. $herecurr);
+ }
+
# recommend qemu_strto* over strto* for numeric conversions
if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
ERROR("consider using qemu_$1 in preference to $1\n" .
$herecurr);
--
2.31.1
- [PATCH v3 20/28] net/colo: Replace g_memdup() by g_memdup2(), (continued)
- [PATCH v3 20/28] net/colo: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [RFC PATCH v3 21/28] ui/clipboard: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [RFC PATCH v3 22/28] linux-user: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 24/28] tests/qtest: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 26/28] target/ppc: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 23/28] tests/unit: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 25/28] target/arm: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 27/28] contrib: Replace g_memdup() by g_memdup2(), Philippe Mathieu-Daudé, 2021/09/03
- [PATCH v3 28/28] checkpatch: Do not allow deprecated g_memdup(),
Philippe Mathieu-Daudé <=