[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/16] tests/acceptance/ppc_prep_40p.py: unify tags
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 16/16] tests/acceptance/ppc_prep_40p.py: unify tags |
Date: |
Mon, 27 Sep 2021 16:45:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 9/24/21 20:55, Cleber Rosa wrote:
> The arch and machine tags apply to all tests, so let's define them
> only once.
IIRC this was not the case at the beginning with Avocado 65.0
at least, right? If so, maybe mention since when it is possible?
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/ppc_prep_40p.py | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/tests/acceptance/ppc_prep_40p.py
> b/tests/acceptance/ppc_prep_40p.py
> index 5e61e686bd..d1e5674673 100644
> --- a/tests/acceptance/ppc_prep_40p.py
> +++ b/tests/acceptance/ppc_prep_40p.py
> @@ -13,6 +13,10 @@
>
>
> class IbmPrep40pMachine(Test):
> + """
> + :avocado: tags=arch:ppc
> + :avocado: tags=machine:40p
> + """
>
> timeout = 60
>
> @@ -24,8 +28,6 @@ class IbmPrep40pMachine(Test):
> @skipUnless(os.getenv('AVOCADO_ALLOW_UNTRUSTED_CODE'), 'untrusted code')
> def test_factory_firmware_and_netbsd(self):
> """
> - :avocado: tags=arch:ppc
> - :avocado: tags=machine:40p
> :avocado: tags=os:netbsd
> :avocado: tags=slowness:high
> """
> @@ -48,10 +50,6 @@ def test_factory_firmware_and_netbsd(self):
> wait_for_console_pattern(self, 'Model: IBM PPS Model 6015')
>
> def test_openbios_192m(self):
> - """
> - :avocado: tags=arch:ppc
> - :avocado: tags=machine:40p
> - """
> self.vm.set_console()
> self.vm.add_args('-m', '192') # test fw_cfg
>
> @@ -62,8 +60,6 @@ def test_openbios_192m(self):
>
> def test_openbios_and_netbsd(self):
> """
> - :avocado: tags=arch:ppc
> - :avocado: tags=machine:40p
> :avocado: tags=os:netbsd
> """
> drive_url = ('https://archive.netbsd.org/pub/NetBSD-archive/'
>
- [PATCH 04/16] Acceptance Tests: keep track and disable tests with known issues, (continued)
- [PATCH 04/16] Acceptance Tests: keep track and disable tests with known issues, Cleber Rosa, 2021/09/24
- [PATCH 11/16] tests/acceptance/boot_xen.py: fetch kernel during test setUp(), Cleber Rosa, 2021/09/24
- [PATCH 12/16] tests/acceptance/boot_xen.py: removed unused import, Cleber Rosa, 2021/09/24
- [PATCH 13/16] tests/acceptance/boot_xen.py: use class attribute, Cleber Rosa, 2021/09/24
- [PATCH 14/16] tests/acceptance/ppc_prep_40p.py: NetBSD 7.1.2 location update, Cleber Rosa, 2021/09/24
- [PATCH 15/16] tests/acceptance/ppc_prep_40p.py: clean up unused import, Cleber Rosa, 2021/09/24
- [PATCH 16/16] tests/acceptance/ppc_prep_40p.py: unify tags, Cleber Rosa, 2021/09/24
- Re: [PATCH 16/16] tests/acceptance/ppc_prep_40p.py: unify tags,
Philippe Mathieu-Daudé <=
- Re: [PATCH 00/16] Acceptance Tests: use Avocado 91.0 features and other improvements, Pavel Dovgalyuk, 2021/09/27
- Re: [PATCH 00/16] Acceptance Tests: use Avocado 91.0 features and other improvements, Philippe Mathieu-Daudé, 2021/09/27