Re: [PATCH] hw/ppc/ppc405_boards: Change kernel load address

[Thomas Huth]

On 02/12/2021 20.14, Cédric Le Goater wrote:
> The default addresses to load the kernel, fdt, initrd of AMCC boards
> in U-Boot v2015.10 are :
>
>         "kernel_addr_r=1000000\0"
>         "fdt_addr_r=1800000\0"
>         "ramdisk_addr_r=1900000\0"
>
> The taihu is one of these boards, the ref405ep is not but we don't
> have much information on it and both boards have a very similar
> address space layout. Change the kernel load address to match U-Boot
> expectations and fix loading.

You could additionally mention that U-Boot corrupts the kernel if it gets 
loaded to address 0.

> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   hw/ppc/ppc405_boards.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c
> index 972a7a4a3e5d..b4249f4626e6 100644
> --- a/hw/ppc/ppc405_boards.c
> +++ b/hw/ppc/ppc405_boards.c
> @@ -45,7 +45,7 @@
>   #define BIOS_FILENAME "ppc405_rom.bin"
>   #define BIOS_SIZE (2 * MiB)
>   
> -#define KERNEL_LOAD_ADDR 0x00000000
> +#define KERNEL_LOAD_ADDR 0x01000000
>   #define INITRD_LOAD_ADDR 0x01800000
>   
>   #define USE_FLASH_BIOS

Reviewed-by: Thomas Huth <thuth@redhat.com>