Re: [PATCH 4/8] ppc/ppc405: Restore TCR and STR write handlers

[Richard Henderson]

On 12/21/21 10:40 PM, Cédric Le Goater wrote:
> The 405 timers were broken when booke support was added. Assumption
> was made that the register numbers were the same but it's not :
>
>      SPR_BOOKE_TSR         (0x150)
>      SPR_BOOKE_TCR         (0x154)
>      SPR_40x_TSR           (0x3D8)
>      SPR_40x_TCR           (0x3DA)
>
> Cc: Christophe Leroy<christophe.leroy@c-s.fr>
> Fixes: ddd1055b07fd ("PPC: booke timers")
> Signed-off-by: Cédric Le Goater<clg@kaod.org>
> ---
>   target/ppc/cpu.h             |  2 ++
>   target/ppc/helper.h          |  2 ++
>   target/ppc/spr_tcg.h         |  2 ++
>   hw/ppc/ppc.c                 | 25 +++++++++++++++++++++++++
>   target/ppc/cpu_init.c        |  4 ++--
>   target/ppc/timebase_helper.c | 10 ++++++++++
>   target/ppc/translate.c       | 12 ++++++++++++
>   hw/ppc/trace-events          |  2 ++
>   8 files changed, 57 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~