Re: [PATCH v2 17/18] ppc/pnv: Introduce user creatable pnv-phb4 devices

[Cédric Le Goater]

> > > +        object_property_set_int(OBJECT(phb), "index",
> > > +                                phb->phb_id, &error_abort);
> > > +
> > > +        pnv_phb4_set_stack_phb_props(stack, phb);
> > > +
> > > +        /* Assign the phb to the stack */
> > > +        stack->phb = phb;
> >
> > The stack object should check the validity of the stack->phb pointer always.
>
>
> What do you mean by "check the validity"?

I am thinking of the usage of 'stack->phb', for instance in the routine
pnv_phb4_update_regions(). We should add an assert there.

Your changes seem to cleanup the stack <-> phb relation quite a lot. Which
is good.

Thanks,

C.