Re: [PATCH v4 25/47] target/ppc: implement vrlq

[Richard Henderson]

On 2/22/22 04:36, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst<matheus.ferst@eldorado.org.br>
>
> Signed-off-by: Matheus Ferst<matheus.ferst@eldorado.org.br>
> ---
> v4:
>   -  New in v4.
> ---
>   target/ppc/insn32.decode            |  1 +
>   target/ppc/translate/vmx-impl.c.inc | 49 +++++++++++++++++++++++++++++
>   2 files changed, 50 insertions(+)
...
> +    tcg_gen_andi_i64(n, n, 0x7F);
> +
> +    tcg_gen_mov_i64(t0, ah);
> +    tcg_gen_movcond_i64(TCG_COND_GE, ah, n, sf, al, ah);
> +    tcg_gen_movcond_i64(TCG_COND_GE, al, n, sf, t0, al);

Similar comment re (n & 64) != 0.  Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>