Re: [PATCH v4 01/18] ppc/xive2: Introduce a XIVE2 core framework

[Cédric Le Goater]

> > +static const TypeInfo xive2_end_source_info = {
> > +    .name          = TYPE_XIVE2_END_SOURCE,
> > +    .parent        = TYPE_DEVICE,
> > +    .instance_size = sizeof(Xive2EndSource),
> > +    .class_init    = xive2_end_source_class_init,
> > +};
>
> This device can be used to crash QEMU:
>
> $ ./qemu-system-ppc64 -nographic  -device xive2-end-source
> qemu-system-ppc64: ../../devel/qemu/hw/intc/xive2.c:966: xive2_end_source_realize: 
> Assertion `xsrc->xrtr' failed.
> Aborted (core dumped)
>
> Should it be user_creatable = false ?

Clearly yes.

Thanks,

C.