Re: [PATCH v4] ppc64: Avoid pt_regs struct definition

[Peter Maydell]

On Tue, 15 Mar 2022 at 02:14, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 3/14/22 18:57, Khem Raj wrote:
> > Remove pt_regs indirection and instead reference gp_regs directly, this
> > makes it portable across musl/glibc
> >
> > Use PT_* constants defined in asm/ptrace.h
> >
> > Move the file to ppc64 subdir and leave ppc empty
> >
> > Fixes
> > ../qemu-6.2.0/linux-user/host/ppc64/../ppc/host-signal.h:16:32: error: 
> > incomplete definition of type 'struct pt_regs'
> >      return uc->uc_mcontext.regs->nip;
> >             ~~~~~~~~~~~~~~~~~~~~^
> >
> > Signed-off-by: Khem Raj<raj.khem@gmail.com>
> > Cc: Peter Maydell<peter.maydell@linaro.org>
> > Cc: Philippe Mathieu-Daudé<f4bug@amsat.org>
> > Cc: Richard Henderson<richard.henderson@linaro.org>
> > ---
> > v2: Drop ifdef __powerpc__
> > v3: Access go_regs directly and move the file to ppc64 dir
> > v4: Use PT_* constants defined in asm/ptrace.h
> >
> >   linux-user/include/host/ppc/host-signal.h   | 38 -------------------
> >   linux-user/include/host/ppc64/host-signal.h | 42 ++++++++++++++++++++-
> >   2 files changed, 41 insertions(+), 39 deletions(-)
> >   delete mode 100644 linux-user/include/host/ppc/host-signal.h
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

I did a compile-check and confirmed that this builds OK
on glibc headers too.

-- PMM