Re: [PATCH v2 06/13] mac_newworld: Simplify creation of Uninorth devices

[Philippe Mathieu-Daudé]

Cc'ing CLI refactor team.

On 29/9/22 09:39, Mark Cave-Ayland wrote:
> On 25/09/2022 13:38, BALATON Zoltan wrote:
>
> > Avoid open coding sysbus_mmio_map() and map regions in ascending
> > otder. Reorganise code a bit to avoid some casts.
> >
> > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > ---
> >   hw/ppc/mac_newworld.c | 42 +++++++++++++++++-------------------------
> >   1 file changed, 17 insertions(+), 25 deletions(-)

> Same comment here re: sysbus. Also the patch seems correct here, but it 
> is worth noting that the PCI bus initialisation is order sensitive: the 
> last bus created is the one that becomes the default PCI bus for 
> -device, so changing this would break quite a few command lines...

Eh, I was not aware of this API fragility. So when using -device without
expliciting the 'bus' key, the default is the latest bus created... OK.