Re: [RFC PATCH v2 09/29] target/ppc: remove generic architecture checks from p9_deliver_interrupt

[Matheus K. Ferst]

On 30/09/2022 15:13, Fabiano Rosas wrote:
> Matheus Ferst <matheus.ferst@eldorado.org.br> writes:
>
> > No functional change intended.
> >
> > Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
> > ---
> >   target/ppc/excp_helper.c | 9 +--------
> >   1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> > index 603c956588..67e73f30ab 100644
> > --- a/target/ppc/excp_helper.c
> > +++ b/target/ppc/excp_helper.c
> > @@ -1919,18 +1919,11 @@ static void p9_deliver_interrupt(CPUPPCState *env, int 
> > interrupt)
> >           break;
> >
> >       case PPC_INTERRUPT_DECR: /* Decrementer exception */
> > -        if (ppc_decr_clear_on_delivery(env)) {
> > -            env->pending_interrupts &= ~PPC_INTERRUPT_DECR;
> > -        }
>
> Maybe I'm missing something, but this should continue to clear the bit,
> no? Same comment for P8.

ppc_decr_clear_on_delivery returns true if (env->tb_env->flags & 
(PPC_DECR_UNDERFLOW_TRIGGERED | PPC_DECR_UNDERFLOW_LEVEL)) ==
PPC_DECR_UNDERFLOW_TRIGGERED, i.e., PPC_DECR_UNDERFLOW_TRIGGERED is set 
and PPC_DECR_UNDERFLOW_LEVEL is clear. All Book3S CPU have a level 
triggered interrupt, so the method return false.

Thanks,
Matheus K. Ferst
Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/>
Analista de Software
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>