Re: [PATCH v7 1/8] ppc440_uc.c: Move DDR2 SDRAM controller model to ppc4xx_sdram.c

[BALATON Zoltan]

On Fri, 21 Oct 2022, Daniel Henrique Barboza wrote:
> > diff --git a/hw/ppc/ppc4xx_sdram.c b/hw/ppc/ppc4xx_sdram.c
> > new file mode 100644
> > index 0000000000..b49a7ed60a
> > --- /dev/null
> > +++ b/hw/ppc/ppc4xx_sdram.c
> > @@ -0,0 +1,348 @@
> > +/*
> > + * DDR2 SDRAM controller:
> > + * Copyright (c) 2012 François Revol
> > + * Copyright (c) 2016-2019 BALATON Zoltan
>
>
> Shouldn't your Copyright be 2016-2022 for this new file?
>
>
> The rest LGTM
>
> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Thanks for the review. I'm not sure about the date. I did not intend to 
increment this every year or with every little change. It mainly records 
the time it was originally wrritten or when major changes were made. I 
can't decide if these changes in this series are big enough to need a new 
copyright date but I don't mind either way so I let you decide. I'm OK 
with it as it is or also if you update it on merge.

Regards,
BALATON Zoltan