Re: [PATCH v4 00/19] Misc ppc/mac machines clean up

[BALATON Zoltan]

On Tue, 25 Oct 2022, BALATON Zoltan wrote:
> Since only one week is left until freeze starts I've included some
> more patches in this version that I've intended to submit after the
> clean ups but we're running out of time now. The last 3 patches could
> be squashed together, I've just split these up because I expect
> resistence from Mark to any changes so maybe it's easier to digest
> piece by piece and can cherry pick parts easier this way but ideally
> these should be in one patch.
>
> I'd appreciate very much if this series would get in before the
> freeze, it is very discouraging to spend time with something that gets
> ignored and then postponed for the rest of the year just to start
> again the same in January. This might be a reason why not many people
> contribute to this part of QEMU besides that maybe only a few people
> are still interested so those who are interested should be served
> better to not scare them off even more.

Found a typo in the last (docs) patch so resent a v5 for just this patch 
and added another patch that could go in now as it works without OpenBIOS 
changes now so changes this allows in OpenBIOS can be done later at any 
time independently but it fixes the problem with ati-vga and qemu_vga.ndrv 
so it's useful for that alone.

Regards,
BALATON Zoltan

> v4: Add some more patches that I've found since v3 or was intended in
> separate series
> v3: Some more patch spliting and changes I've noticed and address more
> review comments
> v2: Split some patches and add a few more I've noticed now and address
> review comments
>
> BALATON Zoltan (19):
>  mac_newworld: Drop some variables
>  mac_oldworld: Drop some more variables
>  mac_{old|new}world: Set tbfreq at declaration
>  mac_{old|new}world: Avoid else branch by setting default value
>  mac_{old|new}world: Simplify cmdline_base calculation
>  mac_newworld: Clean up creation of Uninorth devices
>  mac_{old|new}world: Reduce number of QOM casts
>  hw/ppc/mac.h: Move newworld specific parts out from shared header
>  hw/ppc/mac.h: Move macio specific parts out from shared header
>  hw/ppc/mac.h: Move grackle-pcihost type declaration out to a header
>  hw/ppc/mac.h: Move PROM and KERNEL defines to board code
>  hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h
>  mac_nvram: Use NVRAM_SIZE constant
>  mac_{old|new}world: Code style fix adding missing braces to if-s
>  mac_newworld: Turn CORE99_VIA_CONFIG defines into an enum
>  mac_newworld: Add machine types for different mac99 configs
>  mac_newworld: Deprecate mac99 with G5 CPU
>  mac_newworld: Deprecate mac99 "via" option
>  mac_newworld: Document deprecation
>
> MAINTAINERS                   |   2 +
> docs/about/deprecated.rst     |   7 +
> docs/system/ppc/powermac.rst  |  12 +-
> hw/ide/macio.c                |   1 -
> hw/intc/heathrow_pic.c        |   1 -
> hw/intc/openpic.c             |   1 -
> hw/misc/macio/cuda.c          |   1 -
> hw/misc/macio/gpio.c          |   1 -
> hw/misc/macio/macio.c         |   8 +-
> hw/misc/macio/pmu.c           |   1 -
> hw/nvram/mac_nvram.c          |   2 +-
> hw/pci-host/grackle.c         |  15 +-
> hw/pci-host/uninorth.c        |   1 -
> hw/ppc/mac.h                  | 105 -----------
> hw/ppc/mac_newworld.c         | 341 ++++++++++++++++++++++------------
> hw/ppc/mac_oldworld.c         | 120 ++++++------
> include/hw/misc/macio/macio.h |  23 ++-
> include/hw/nvram/mac_nvram.h  |  51 +++++
> include/hw/pci-host/grackle.h |  44 +++++
> 19 files changed, 415 insertions(+), 322 deletions(-)
> delete mode 100644 hw/ppc/mac.h
> create mode 100644 include/hw/nvram/mac_nvram.h
> create mode 100644 include/hw/pci-host/grackle.h