Re: [PATCH v3 00/13] Misc ppc/mac machines clean up

[Mark Cave-Ayland]

On 18/10/2022 12:37, BALATON Zoltan wrote:

> On Tue, 11 Oct 2022, BALATON Zoltan wrote:
> > On Mon, 3 Oct 2022, BALATON Zoltan wrote:
> > > This series includes some clean ups to mac_newworld and mac_oldworld
> > > to make them a bit simpler and more readable, It also removes the
> > > shared mac.h file that turns out was more of a random collection of
> > > unrelated things. Getting rid of this mac.h improves the locality of
> > > device models and reduces unnecessary interdependency.
> >
> > Ping?
>
> Ping^2 Only patch 4-5 still need a review. This series is a quite simple clean up 
> with no functional change and it's on the list for a month now with this v3 is 
> waiting for the last two weeks. I hoped to do some more changes after this was merged 
> but with this rate of maintainer activity I'm not sure even this simple clean up can 
> make it until the freeze and there seems to be no hope to get in more changes this 
> year, We need to do something about this situation as it hinders development. It 
> should not be so difficult to make even simple changes.

I've had a look at patch 4 in the v3 series and that seems okay to me (I think I may 
have simply missed adding a R-B tag?), so if you can resend a v4 with patch 5 removed 
then I will send a PR for before freeze.

I appreciate that the rate of patch review can be frustrating, but this is something 
that is true for all QEMU developers. Remember there is no commercial sponsorship for 
the Mac PPC machines so the speed of review and testing is often limited by work 
deadlines and/or personal circumstances.


ATB,

Mark.