qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 00/19] Misc ppc/mac machines clean up


From: BALATON Zoltan
Subject: Re: [PATCH v6 00/19] Misc ppc/mac machines clean up
Date: Sun, 30 Oct 2022 23:23:31 +0100 (CET)

On Sun, 30 Oct 2022, Mark Cave-Ayland wrote:
On 28/10/2022 12:56, BALATON Zoltan wrote:
Since only one week is left until freeze starts I've included some
more patches in this version that I've intended to submit after the
clean ups but we're running out of time now. The last 3 patches could
be squashed together, I've just split these up because I expect
resistence from Mark to any changes so maybe it's easier to digest
piece by piece and can cherry pick parts easier this way but ideally
these should be in one patch.

I'd appreciate very much if this series would get in before the
freeze, it is very discouraging to spend time with something that gets
ignored and then postponed for the rest of the year just to start
again the same in January. This might be a reason why not many people
contribute to this part of QEMU besides that maybe only a few people
are still interested so those who are interested should be served
better to not scare them off even more.

Regards,
BALATON Zoltan

v6: Drop cmdline_base patch
v5: Fix last patch and add one more patch to fix NDRV with ati-vga
v4: Add some more patches that I've found since v3 or was intended in
separate series
v3: Some more patch spliting and changes I've noticed and address more
review comments
v2: Split some patches and add a few more I've noticed now and address
review comments

BALATON Zoltan (19):
   mac_newworld: Drop some variables
   mac_oldworld: Drop some more variables
   mac_{old|new}world: Set tbfreq at declaration
   mac_{old|new}world: Avoid else branch by setting default value
   mac_newworld: Clean up creation of Uninorth devices
   mac_{old|new}world: Reduce number of QOM casts
   hw/ppc/mac.h: Move newworld specific parts out from shared header
   hw/ppc/mac.h: Move macio specific parts out from shared header
   hw/ppc/mac.h: Move grackle-pcihost type declaration out to a header
   hw/ppc/mac.h: Move PROM and KERNEL defines to board code
   hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h
   mac_nvram: Use NVRAM_SIZE constant
   mac_{old|new}world: Code style fix adding missing braces to if-s
   mac_newworld: Turn CORE99_VIA_CONFIG defines into an enum
   mac_newworld: Add machine types for different mac99 configs
   mac_newworld: Deprecate mac99 with G5 CPU
   mac_newworld: Deprecate mac99 "via" option
   mac_newworld: Document deprecation
   mac_{old,new}world: Pass MacOS VGA NDRV in card ROM instead of fw_cfg

  MAINTAINERS                   |   2 +
  docs/about/deprecated.rst     |   7 +
  docs/system/ppc/powermac.rst  |  12 +-
  hw/ide/macio.c                |   1 -
  hw/intc/heathrow_pic.c        |   1 -
  hw/intc/openpic.c             |   1 -
  hw/misc/macio/cuda.c          |   1 -
  hw/misc/macio/gpio.c          |   1 -
  hw/misc/macio/macio.c         |   8 +-
  hw/misc/macio/pmu.c           |   1 -
  hw/nvram/mac_nvram.c          |   2 +-
  hw/pci-host/grackle.c         |  15 +-
  hw/pci-host/uninorth.c        |   1 -
  hw/ppc/mac.h                  | 105 ----------
  hw/ppc/mac_newworld.c         | 353 ++++++++++++++++++++++------------
  hw/ppc/mac_oldworld.c         | 131 ++++++-------
  include/hw/misc/macio/macio.h |  23 ++-
  include/hw/nvram/mac_nvram.h  |  51 +++++
  include/hw/pci-host/grackle.h |  44 +++++
  19 files changed, 421 insertions(+), 339 deletions(-)
  delete mode 100644 hw/ppc/mac.h
  create mode 100644 include/hw/nvram/mac_nvram.h
  create mode 100644 include/hw/pci-host/grackle.h

I've queued patches 1-14 in my qemu-macppc branch (whilst fixing the typos in the description for patch 5) and will send a PR in time for soft freeze.

Thanks. Sorry about the typos, looks like I missed two in that patch: otder -> order and reorganise. Did you fix both?

What about the remaining patches?

Regards,
BALATON Zoltan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]