Re: [PATCH 0/6] Trivial PPC cleanups

[Bernhard Beschow]

Am 16. Dezember 2022 15:32:00 UTC schrieb "Cédric Le Goater" <clg@kaod.org>:
>On 12/16/22 15:57, Bernhard Beschow wrote:
>> These are some patches which helped me when getting a u-boot image to run on 
>> ppce500 machine.
>
>Nice. Did you simply use the qemu-ppce500_defconfig ? or an u-boot old image ?

I used P1020RDB-PC_NAND_defconfig from the u-boot repository plus my branch 
https://github.com/shentok/qemu/commits/e500-u-boot . I had to comment out the 
fdt handling in u-boot for now since I didn't figure out yet how to include the 
dt blob in the elf binary. Anyway, with this I get a u-boot shell!

>
>We could update the qemu_ppc_e500mc_defconfig in buildroot to generate the
>uboot.bin if that worked.

I haven't looked into that yet but this sounds interesting!

Best regards,
Bernhard

>
>
>> 
>> Testing done:
>> - `make check`
>> - `make check-avocado`
>> 
>> Bernhard Beschow (6):
>>    target/ppc/mmu_common: Log which effective address had no TLB entry
>>      found
>>    target/ppc/mmu_common: Fix table layout of "info tlb" HMP command
>>    hw/ppc/virtex_ml507: Prefer local over global variable
>>    hw/ppc/e500: Prefer local variable over qdev_get_machine()
>>    hw/ppc/e500: Resolve variable shadowing
>>    hw/ppc/e500: Move comment to more appropriate place
>> 
>>   hw/ppc/e500.c           | 10 ++++------
>>   hw/ppc/virtex_ml507.c   |  2 +-
>>   target/ppc/mmu_common.c |  5 +++--
>>   3 files changed, 8 insertions(+), 9 deletions(-)
>> 
>
>
>Reviewed-by: Cédric Le Goater <clg@kaod.org>
>
>Thanks,
>
>C.