[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/15] hw/display/sm501: Unify common QOM properties
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 12/15] hw/display/sm501: Unify common QOM properties |
Date: |
Fri, 3 Feb 2023 15:55:33 +0100 |
Since now PCI and SysBus properties are identical, unify them.
Suggested-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/display/sm501.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index efebd93f1e..98375138b2 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -1975,7 +1975,7 @@ static void sm501_realize_sysbus(DeviceState *dev, Error
**errp)
/* TODO : chain irq to IRL */
}
-static Property sm501_sysbus_properties[] = {
+static Property sm501_common_properties[] = {
DEFINE_PROP_UINT32("vram-size", SM501SysBusState, vram_size, 0),
DEFINE_PROP_END_OF_LIST(),
};
@@ -2004,7 +2004,7 @@ static void sm501_sysbus_class_init(ObjectClass *klass,
void *data)
dc->realize = sm501_realize_sysbus;
set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
dc->desc = "SM501 Multimedia Companion";
- device_class_set_props(dc, sm501_sysbus_properties);
+ device_class_set_props(dc, sm501_common_properties);
dc->reset = sm501_reset_sysbus;
dc->vmsd = &vmstate_sm501_sysbus;
}
@@ -2062,11 +2062,6 @@ static void sm501_realize_pci(PCIDevice *dev, Error
**errp)
&s->state.mmio_region);
}
-static Property sm501_pci_properties[] = {
- DEFINE_PROP_UINT32("vram-size", SM501PCIState, vram_size, 64 * MiB),
- DEFINE_PROP_END_OF_LIST(),
-};
-
static void sm501_reset_pci(DeviceState *dev)
{
SM501PCIState *s = PCI_SM501(dev);
@@ -2098,7 +2093,7 @@ static void sm501_pci_class_init(ObjectClass *klass, void
*data)
k->class_id = PCI_CLASS_DISPLAY_OTHER;
set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
dc->desc = "SM501 Display Controller";
- device_class_set_props(dc, sm501_pci_properties);
+ device_class_set_props(dc, sm501_common_properties);
dc->reset = sm501_reset_pci;
dc->hotpluggable = false;
dc->vmsd = &vmstate_sm501_pci;
--
2.38.1
- [PATCH v2 04/15] hw/pci/pcie_sriov: Do not open-code qdev_unrealize_and_unref(), (continued)
- [PATCH v2 04/15] hw/pci/pcie_sriov: Do not open-code qdev_unrealize_and_unref(), Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 05/15] hw/i386/sgx: Do not open-code qdev_realize_and_unref(), Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 06/15] hw/ppc/sam460ex: Correctly set MAL properties, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 07/15] hw/arm/nrf51: Alias 'flash-size' QOM property in SoC object, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 08/15] hw/arm/fsl-imx: Alias 'phy-num' QOM property in SoC object, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 09/15] hw/usb/hcd-ohci: Include missing 'sysbus.h' header, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 10/15] hw/display/sm501: Embed OHCI QOM child in chipset, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 11/15] hw/display/sm501: Alias 'dma-offset' QOM property in chipset object, Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 12/15] hw/display/sm501: Unify common QOM properties,
Philippe Mathieu-Daudé <=
- [PATCH v2 13/15] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h', Philippe Mathieu-Daudé, 2023/02/03
- [PATCH v2 14/15] hw/mips: Declare all length properties as unsigned, Philippe Mathieu-Daudé, 2023/02/03
- [RFC PATCH v2 15/15] hw/mips/itu: Pass SAAR using QOM link property, Philippe Mathieu-Daudé, 2023/02/03