qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/display/sm501: Implement more 2D raster operations


From: BALATON Zoltan
Subject: Re: [PATCH] hw/display/sm501: Implement more 2D raster operations
Date: Sun, 26 Feb 2023 23:16:24 +0100 (CET)

On Sun, 26 Feb 2023, Philippe Mathieu-Daudé wrote:
On 16/2/23 15:40, BALATON Zoltan wrote:
Add simple implementation for two raster operations that are used by
AmigaOS which fixes graphics problems in some progtams using these.

Typo "programs".

Fixed in v3 (was just in time for that :-) ).

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
For definitions of these see:
https://learn.microsoft.com/en-us/windows/win32/gdi/ternary-raster-operations

Comment worth being in the commit description IMO.

I don't think adding URLs to the source that can remain the same for years while URLs can go away is a good idea. It's only here to help review.

Regards,
BALATON Zoltan

  hw/display/sm501.c | 30 +++++++++++++++++++++++++++++-
  1 file changed, 29 insertions(+), 1 deletion(-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]