[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] ppc: spapr: assert early rather late in h_enter_nested()
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH 3/5] ppc: spapr: assert early rather late in h_enter_nested() |
Date: |
Fri, 14 Apr 2023 08:55:29 -0300 |
Harsh Prateek Bora <harshpb@linux.ibm.com> writes:
> Currently, it asserts very late in the code flow if lpid is already
> initialized.
That's not about initializing. It is about making sure the LPIDR is
0. Which has a specific meaning according to the ISA.
> Ideally, it should assert in the beginning if that is the case. This patch
> brings assert check in the beginning alongwith the related initialization.
>
Maybe just leave it where it is. There's not much to gain from moving this.
- Re: [PATCH 3/5] ppc: spapr: assert early rather late in h_enter_nested(),
Fabiano Rosas <=