[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tcg: ppc64: Fix mask generation for vextractdm
From: |
Alex Bennée |
Subject: |
Re: [PATCH 1/2] tcg: ppc64: Fix mask generation for vextractdm |
Date: |
Tue, 02 May 2023 10:03:32 +0100 |
User-agent: |
mu4e 1.11.4; emacs 29.0.90 |
Shivaprasad G Bhat <sbhat@linux.ibm.com> writes:
> In function do_extractm() the mask is calculated as
> dup_const(1 << (element_width - 1)). '1' being signed int
> works fine for MO_8,16,32. For MO_64, on PPC64 host
> this ends up becoming 0 on compilation. The vextractdm
> uses MO_64, and it ends up having mask as 0.
>
> Explicitly use 1ULL instead of signed int 1 like its
> used everywhere else.
>
> Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- Re: [PATCH 1/2] tcg: ppc64: Fix mask generation for vextractdm,
Alex Bennée <=