qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.


From: Richard Henderson
Subject: Re: [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.
Date: Wed, 3 May 2023 11:09:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 5/3/23 10:36, Harsh Prateek Bora wrote:
The bits in cr reg are grouped into eight 4-bit fields represented
by env->crf[8] and the related calculations should be abstracted to
keep the calling routines simpler to read. This is a step towards
cleaning up the related/calling code for better readability.

Signed-off-by: Harsh Prateek Bora<harshpb@linux.ibm.com>
Reviewed-by: Fabiano Rosas<farosas@suse.de>
---
  hw/ppc/spapr_hcall.c      | 18 ++----------------
  linux-user/elfload.c      |  4 +---
  linux-user/ppc/signal.c   |  9 ++-------
  target/ppc/cpu.c          | 17 +++++++++++++++++
  target/ppc/cpu.h          |  2 ++
  target/ppc/gdbstub.c      | 22 ++++------------------
  target/ppc/kvm.c          | 13 ++-----------
  target/ppc/ppc-qmp-cmds.c |  6 +-----
  8 files changed, 31 insertions(+), 60 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]