Re: [PATCH 2/6] hw/ide/via: Wire up IDE legacy interrupts in host device

[BALATON Zoltan]

On Sun, 21 May 2023, BALATON Zoltan wrote:
> On Sun, 21 May 2023, Bernhard Beschow wrote:
> > Resolves circular depencency between IDE function and south bridge.
> >
> > Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> > Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > ---
> > hw/ide/via.c      | 6 ++++--
> > hw/isa/vt82c686.c | 5 +++++
> > 2 files changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/ide/via.c b/hw/ide/via.c
> > index 177baea9a7..0caae52276 100644
> > --- a/hw/ide/via.c
> > +++ b/hw/ide/via.c
> > @@ -31,6 +31,7 @@
> > #include "sysemu/dma.h"
> > #include "hw/isa/vt82c686.h"
> > #include "hw/ide/pci.h"
> > +#include "hw/irq.h"
> > #include "trace.h"
> >
> > static uint64_t bmdma_read(void *opaque, hwaddr addr,
> > @@ -104,7 +105,8 @@ static void bmdma_setup_bar(PCIIDEState *d)
> >
> > static void via_ide_set_irq(void *opaque, int n, int level)
> > {
> > -    PCIDevice *d = PCI_DEVICE(opaque);
> > +    PCIIDEState *s = opaque;
> > +    PCIDevice *d = PCI_DEVICE(s);
>
> These are the same structure so can be cast into each other but for 
> consistency it's better to also change
>
> qdev_init_gpio_in(ds, via_ide_set_irq, ARRAY_SIZE(d->bus));
>
> to pass the PCIIDEState so d instead of ds in via_ide_realize().

Ignore this. That function takes a DeviceState and seems no separate 
argument for the opaque pointer so no change is needed.

Regards,
BALATON Zoltan