Re: [PATCH] ppc/pegasos2: Change default CPU to 7457

[BALATON Zoltan]

On Sun, 28 May 2023, Rene Engel wrote:
> --- Ursprüngliche Nachricht ---
> Von: BALATON Zoltan <balaton@eik.bme.hu>
> Datum: 28.05.2023 17:29:37
> An: qemu-devel@nongnu.org,     qemu-ppc@nongnu.org
> Betreff: [PATCH] ppc/pegasos2: Change default CPU to 7457
>
> > Previously 7400 was selected as a safe choice as that is used by other
> > machines so it's better tested but AmigaOS does not know this CPU and
> > disables some features when running on it. The real hardware has
> > 7447/7457 G4 CPU so change the default to match that now that it was
> > confirmed to work better with AmigaOS.
>
> Can't we also increase the memory "mc->default_ram_size = 512 * MiB;" to 1024 
> for default settings ?
> Long term tests have confirmed that it works very well with 1024 MB memory 
> under AmigaOs4.1.

No, the default memory size is not the largest possible but something sane 
that works bur won't eat all the memory of the host. Nowadays it's less of 
an issue but the default for most machines are still 128MB which I've 
already increased to 512MB for these machines as this is a better value 
for Amiga like OSes running on these machines but larger default may be 
too much. Adding a -memory option is less confusing then picking the right 
CPU type so requiring that for more memory is less of a problem.

Regards,
BALATON Zoltan

> > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > Tested-by: Rene Engel <ReneEngel80@emailn.de>
> > ---
> >  hw/ppc/pegasos2.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
> > index f1650be5ee..af5489de26 100644
> > --- a/hw/ppc/pegasos2.c
> > +++ b/hw/ppc/pegasos2.c
> > @@ -524,7 +524,7 @@ static void pegasos2_machine_class_init(ObjectClass *oc,
> > void *data)
> >      mc->block_default_type = IF_IDE;
> >      mc->default_boot_order = "cd";
> >      mc->default_display = "std";
> > -    mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("7400_v2.9");
> >
> > +    mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("7457_v1.2");
> >
> >      mc->default_ram_id = "pegasos2.ram";
> >      mc->default_ram_size = 512 * MiB;
> >
> > --
> > 2.30.9