Re: [PATCH 08/10] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE

[Philippe Mathieu-Daudé]

On 30/5/23 15:11, David Hildenbrand wrote:
> On 30.05.23 15:07, Michael S. Tsirkin wrote:
> > On Tue, May 30, 2023 at 01:38:36PM +0200, David Hildenbrand wrote:
> > > There are no remaining users in the tree, so let's remove it.
> > >
> > > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > > Cc: Richard Henderson <richard.henderson@linaro.org>
> > > Cc: Eduardo Habkost <eduardo@habkost.net>
> > > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > > Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> > > Signed-off-by: David Hildenbrand <david@redhat.com>
> >
> >
> > This (with previous patches) means any user changing
> > device-memory-region-size machine property is now broken, right?
>
> We only had a getter, no setter (for good reason).
>
> > How do we know there are no users?
>
> We don't. A quick google search makes "device-memory-region-size" and 
> "qom-get" only pop up in BUG fixes for something that appears to be QEMU 
> developer driven.

This was my analysis.
> I don't consider it any useful, but if we want to be careful, sure we 
> can leave it around.

If we want to keep it, we should move it to generic code IMHO,
not PC machine. Otherwise the less unused code the better :)