[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 13/14] ppc440_pcix: Don't use iomem for regs
From: |
BALATON Zoltan |
Subject: |
[PATCH v2 13/14] ppc440_pcix: Don't use iomem for regs |
Date: |
Wed, 5 Jul 2023 22:12:58 +0200 (CEST) |
The iomem memory region is better used for the PCI IO space but
currently used for registers. Stop using it for that to allow this to
be cleaned up in the next patch.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/ppc/ppc440_pcix.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c
index adfecf1e76..cf932e4b25 100644
--- a/hw/ppc/ppc440_pcix.c
+++ b/hw/ppc/ppc440_pcix.c
@@ -63,6 +63,7 @@ struct PPC440PCIXState {
MemoryRegion container;
MemoryRegion iomem;
MemoryRegion busmem;
+ MemoryRegion regs;
};
#define PPC440_REG_BASE 0x80000
@@ -507,11 +508,11 @@ static void ppc440_pcix_realize(DeviceState *dev, Error
**errp)
h, "pci-conf-idx", 4);
memory_region_init_io(&h->data_mem, OBJECT(s), &pci_host_data_le_ops,
h, "pci-conf-data", 4);
- memory_region_init_io(&s->iomem, OBJECT(s), &pci_reg_ops, s,
- "pci.reg", PPC440_REG_SIZE);
+ memory_region_init_io(&s->regs, OBJECT(s), &pci_reg_ops, s, "pci-reg",
+ PPC440_REG_SIZE);
memory_region_add_subregion(&s->container, PCIC0_CFGADDR, &h->conf_mem);
memory_region_add_subregion(&s->container, PCIC0_CFGDATA, &h->data_mem);
- memory_region_add_subregion(&s->container, PPC440_REG_BASE, &s->iomem);
+ memory_region_add_subregion(&s->container, PPC440_REG_BASE, &s->regs);
sysbus_init_mmio(sbd, &s->container);
}
--
2.30.9
- [PATCH v2 04/14] ppc440: Rename parent field of PPC460EXPCIEState to match code style, (continued)
- [PATCH v2 04/14] ppc440: Rename parent field of PPC460EXPCIEState to match code style, BALATON Zoltan, 2023/07/05
- [PATCH v2 08/14] ppc440: Add busnum property to PCIe controller model, BALATON Zoltan, 2023/07/05
- [PATCH v2 05/14] ppc440: Rename local variable in dcr_read_pcie(), BALATON Zoltan, 2023/07/05
- [PATCH v2 09/14] ppc440: Remove ppc460ex_pcie_init legacy init function, BALATON Zoltan, 2023/07/05
- [PATCH v2 07/14] ppc/sam460ex: Remove address_space_mem local variable, BALATON Zoltan, 2023/07/05
- [PATCH v2 10/14] ppc4xx_pci: Rename QOM type name define, BALATON Zoltan, 2023/07/05
- [PATCH v2 14/14] ppc440_pcix: Stop using system io region for PCI bus, BALATON Zoltan, 2023/07/05
- [PATCH v2 11/14] ppc4xx_pci: Add define for ppc4xx-host-bridge type name, BALATON Zoltan, 2023/07/05
- [PATCH v2 12/14] ppc440_pcix: Rename QOM type define abd move it to common header, BALATON Zoltan, 2023/07/05
- [PATCH v2 13/14] ppc440_pcix: Don't use iomem for regs,
BALATON Zoltan <=
- Re: [PATCH v2 00/14] PPC440 devices misc clean up, BALATON Zoltan, 2023/07/05
- Re: [PATCH v2 00/14] PPC440 devices misc clean up, Daniel Henrique Barboza, 2023/07/05