qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 09/24] target/riscv: Use GDBFeature for dynamic XML


From: Philippe Mathieu-Daudé
Subject: Re: [RFC PATCH 09/24] target/riscv: Use GDBFeature for dynamic XML
Date: Mon, 31 Jul 2023 15:46:41 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 31/7/23 10:43, Akihiko Odaki wrote:
In preparation for a change to use GDBFeature as a parameter of
gdb_register_coprocessor(), convert the internal representation of
dynamic feature from plain XML to GDBFeature.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
  target/riscv/cpu.h     |  4 ++--
  target/riscv/cpu.c     |  4 ++--
  target/riscv/gdbstub.c | 25 ++++++++++++++-----------
  3 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 6ea22e0eea..f67751d5b7 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -391,8 +391,8 @@ struct ArchCPU {
      CPUNegativeOffsetState neg;
      CPURISCVState env;
- char *dyn_csr_xml;
-    char *dyn_vreg_xml;
+    GDBFeature dyn_csr_feature;
+    GDBFeature dyn_vreg_feature;

Similar comment that ARM (dyn_features array).

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]