[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/19] ppc/vof: Fix missed fields in VOF cleanup
From: |
Nicholas Piggin |
Subject: |
[PATCH v2 02/19] ppc/vof: Fix missed fields in VOF cleanup |
Date: |
Tue, 8 Aug 2023 14:19:44 +1000 |
Failing to reset the of_instance_last makes ihandle allocation continue
to increase, which causes record-replay replay fail to match the
recorded trace.
Not resetting claimed_base makes VOF eventually run out of memory after
some resets.
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
Fixes: fc8c745d501 ("spapr: Implement Open Firmware client interface")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
hw/ppc/vof.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c
index 18c3f92317..e3b430a81f 100644
--- a/hw/ppc/vof.c
+++ b/hw/ppc/vof.c
@@ -1024,6 +1024,8 @@ void vof_cleanup(Vof *vof)
}
vof->claimed = NULL;
vof->of_instances = NULL;
+ vof->of_instance_last = 0;
+ vof->claimed_base = 0;
}
void vof_build_dt(void *fdt, Vof *vof)
--
2.40.1
- [PATCH v2 for-8.2 00/19] ppc: record-replay enablement and fixes, Nicholas Piggin, 2023/08/08
- [PATCH v2 01/19] ppc/vhyp: reset exception state when handling vhyp hcall, Nicholas Piggin, 2023/08/08
- [PATCH v2 02/19] ppc/vof: Fix missed fields in VOF cleanup,
Nicholas Piggin <=
- [PATCH v2 03/19] hw/ppc/ppc.c: Tidy over-long lines, Nicholas Piggin, 2023/08/08
- [PATCH v2 04/19] hw/ppc: Introduce functions for conversion between timebase and nanoseconds, Nicholas Piggin, 2023/08/08
- [PATCH v2 05/19] host-utils: Add muldiv64_round_up, Nicholas Piggin, 2023/08/08
- [PATCH v2 06/19] hw/ppc: Round up the decrementer interval when converting to ns, Nicholas Piggin, 2023/08/08
- [PATCH v2 07/19] hw/ppc: Avoid decrementer rounding errors, Nicholas Piggin, 2023/08/08
- [PATCH v2 08/19] target/ppc: Sign-extend large decrementer to 64-bits, Nicholas Piggin, 2023/08/08
- [PATCH v2 09/19] hw/ppc: Always store the decrementer value, Nicholas Piggin, 2023/08/08
- [PATCH v2 10/19] target/ppc: Migrate DECR SPR, Nicholas Piggin, 2023/08/08