qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RESEND v5 13/26] hw/core/cpu: Return static value with gdb_ar


From: Alex Bennée
Subject: Re: [PATCH RESEND v5 13/26] hw/core/cpu: Return static value with gdb_arch_name()
Date: Wed, 30 Aug 2023 16:00:56 +0100
User-agent: mu4e 1.11.16; emacs 29.1.50

Akihiko Odaki <akihiko.odaki@daynix.com> writes:

> All implementations of gdb_arch_name() returns dynamic duplicates of
> static strings. It's also unlikely that there will be an implementation
> of gdb_arch_name() that returns a truly dynamic value due to the nature
> of the function returning a well-known identifiers. Qualify the value
> gdb_arch_name() with const and make all of its implementations return
> static strings.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro



reply via email to

[Prev in Thread] Current Thread [Next in Thread]