Re: [PATCH RESEND 01/15] ppc: spapr: Introduce Nested PAPR API related macros

[Harsh Prateek Bora]

On 9/7/23 05:18, Nicholas Piggin wrote:
> On Wed Sep 6, 2023 at 2:33 PM AEST, Harsh Prateek Bora wrote:
> > Adding new macros for the new hypercall op-codes, their return codes,
> > Guest State Buffer (GSB) element IDs and few registers which shall be
> > used in following patches to support Nested PAPR API.
> >
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> > Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
> > Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
> > ---
> >   include/hw/ppc/spapr.h        |  23 ++++-
> >   include/hw/ppc/spapr_nested.h | 186 ++++++++++++++++++++++++++++++++++
> >   target/ppc/cpu.h              |   2 +
> >   3 files changed, 209 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
> > index 538b2dfb89..3990fed1d9 100644
> > --- a/include/hw/ppc/spapr.h
> > +++ b/include/hw/ppc/spapr.h
> > @@ -367,6 +367,16 @@ struct SpaprMachineState {
> >   #define H_NOOP            -63
> >   #define H_UNSUPPORTED     -67
> >   #define H_OVERLAP         -68
> > +#define H_STATE           -75
>
> [snip]
>
> I didn't go through to make sure all the numbers are correct, but
> generally looks okay. Are these just copied from KVM sources (or
> vice versa)?

I have mostly referred PAPR spec for the numbers. I hope KVM sources 
follows the same.

> > diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> > index 25fac9577a..6f7f9b9d58 100644
> > --- a/target/ppc/cpu.h
> > +++ b/target/ppc/cpu.h
> > @@ -1587,9 +1587,11 @@ void ppc_compat_add_property(Object *obj, const char 
> > *name,
> >   #define SPR_PSPB              (0x09F)
> >   #define SPR_DPDES             (0x0B0)
> >   #define SPR_DAWR0             (0x0B4)
> > +#define SPR_DAWR1             (0x0B5)
> >   #define SPR_RPR               (0x0BA)
> >   #define SPR_CIABR             (0x0BB)
> >   #define SPR_DAWRX0            (0x0BC)
> > +#define SPR_DAWRX1            (0x0BD)
> >   #define SPR_HFSCR             (0x0BE)
> >   #define SPR_VRSAVE            (0x100)
> >   #define SPR_USPRG0            (0x100)
>
> Stray change? Should be in 2nd DAWR patch, presumably.

This was introduced here following the PAPR ACR spec for nested API 
initially to support GSB get/set requests. However, I can update the 
patch once the 2nd DAWR patch gets merged.

Thanks for reviewing the series.

regards,
Harsh

> Thanks,
> Nick