qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 8/8] spapr/drc: Clean up local variable shadowing in prop_get


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 8/8] spapr/drc: Clean up local variable shadowing in prop_get_fdt()
Date: Mon, 18 Sep 2023 17:30:40 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1

On 18/9/23 16:58, Cédric Le Goater wrote:
Rename 'name' variable to avoid this warning :

   ../hw/ppc/spapr_drc.c: In function ‘prop_get_fdt’:
   ../hw/ppc/spapr_drc.c:344:21: warning: declaration of ‘name’ shadows a 
parameter [-Wshadow=compatible-local]
     344 |         const char *name = NULL;
         |                     ^~~~
   ../hw/ppc/spapr_drc.c:325:63: note: shadowed declaration is here
     325 | static void prop_get_fdt(Object *obj, Visitor *v, const char *name,
         |                                                   ~~~~~~~~~~~~^~~~

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
  hw/ppc/spapr_drc.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]