Re: [PATCH v2 13/15] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'

[Paolo Bonzini]

On 9/25/23 13:03, Markus Armbruster wrote:
> +David
>
> Markus Armbruster <armbru@redhat.com> writes:
>
> > Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> >
> > > DEFINE_PROP_DMAADDR() is only used once. Since it doesn't
> > > add much value, simply remove it, along with the header
> > > defining it.
> > >
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> >
> > DEFINE_PROP_DMAADDR() lets you wrap a property around a dma_addr_t
> > member without assuming anything about dma_addr_t.
> >
> > Whether that's worth avoiding I can't say.  Depends on how much the
> > abstraction leaks in other ways.  Thoughts?

I think it's okay to simplify things.  If anybody ever has a reason to 
make dma_addr_t variable sized (probably a bad idea because many of its 
users are compiled once only) they have one extra place to fix.  Tough 
luck. :)

Paolo