qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/13] fuzz: Correct invalid mentions of 'softmmu' by 'system


From: Alexander Bulekov
Subject: Re: [PATCH 04/13] fuzz: Correct invalid mentions of 'softmmu' by 'system'
Date: Wed, 4 Oct 2023 05:22:48 -0400

Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
Thank you

On 231004 1106, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  tests/qtest/fuzz/fuzz.h | 4 ++--
>  softmmu/memory.c        | 2 +-
>  tests/qtest/fuzz/fuzz.c | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/qtest/fuzz/fuzz.h b/tests/qtest/fuzz/fuzz.h
> index 21d1362d65..7da0bc3d7e 100644
> --- a/tests/qtest/fuzz/fuzz.h
> +++ b/tests/qtest/fuzz/fuzz.h
> @@ -49,13 +49,13 @@ typedef struct FuzzTarget {
>  
>  
>      /*
> -     * Returns the arguments that are passed to qemu/softmmu init(). Freed by
> +     * Returns the arguments that are passed to qemu/system init(). Freed by
>       * the caller.
>       */
>      GString *(*get_init_cmdline)(struct FuzzTarget *);
>  
>      /*
> -     * will run once, prior to running qemu/softmmu init.
> +     * will run once, prior to running qemu/system init.
>       * eg: set up shared-memory for communication with the child-process
>       * Can be NULL
>       */
> diff --git a/softmmu/memory.c b/softmmu/memory.c
> index 234bd7b116..fa1c99f9ba 100644
> --- a/softmmu/memory.c
> +++ b/softmmu/memory.c
> @@ -3638,7 +3638,7 @@ void memory_region_init_rom_device(MemoryRegion *mr,
>  }
>  
>  /*
> - * Support softmmu builds with CONFIG_FUZZ using a weak symbol and a stub for
> + * Support system builds with CONFIG_FUZZ using a weak symbol and a stub for
>   * the fuzz_dma_read_cb callback
>   */
>  #ifdef CONFIG_FUZZ
> diff --git a/tests/qtest/fuzz/fuzz.c b/tests/qtest/fuzz/fuzz.c
> index 3bedb81b32..9b9c9f9c36 100644
> --- a/tests/qtest/fuzz/fuzz.c
> +++ b/tests/qtest/fuzz/fuzz.c
> @@ -207,7 +207,7 @@ int LLVMFuzzerInitialize(int *argc, char ***argv, char 
> ***envp)
>          fuzz_target->pre_vm_init();
>      }
>  
> -    /* Run QEMU's softmmu main with the fuzz-target dependent arguments */
> +    /* Run QEMU's system main with the fuzz-target dependent arguments */
>      cmd_line = fuzz_target->get_init_cmdline(fuzz_target);
>      g_string_append_printf(cmd_line, " %s -qtest /dev/null ",
>                             getenv("QTEST_LOG") ? "" : "-qtest-log none");
> -- 
> 2.41.0
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]