qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] target/ppc: Rename variables to avoid local variable shad


From: Markus Armbruster
Subject: Re: [PATCH v2] target/ppc: Rename variables to avoid local variable shadowing in VUPKPX
Date: Wed, 04 Oct 2023 12:38:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Cédric Le Goater <clg@kaod.org> writes:

> and fix such warnings :
>
>   ../target/ppc/int_helper.c: In function ‘helper_vupklpx’:
>   ../target/ppc/int_helper.c:2025:21: warning: declaration of ‘r’ shadows a 
> parameter [-Wshadow=local]
>    2025 |             uint8_t r = (e >> 10) & 0x1f;                           
>     \
>         |                     ^
>   ../target/ppc/int_helper.c:2033:1: note: in expansion of macro ‘VUPKPX’
>    2033 | VUPKPX(lpx, UPKLO)
>         | ^~~~~~
>   ../target/ppc/int_helper.c:2017:41: note: shadowed declaration is here
>    2017 |     void helper_vupk##suffix(ppc_avr_t *r, ppc_avr_t *b)            
>     \
>         |                              ~~~~~~~~~~~^
>   ../target/ppc/int_helper.c:2033:1: note: in expansion of macro ‘VUPKPX’
>    2033 | VUPKPX(lpx, UPKLO)
>         | ^~~~~~
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Queued.  Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]