Re: [PATCH 1/7] hw/ppc/spapr: Restrict PPCTimebase structure declaration to sPAPR

[Philippe Mathieu-Daudé]

Hi Mark,

On 13/10/23 20:32, Mark Cave-Ayland wrote:
> On 13/10/2023 13:56, Philippe Mathieu-Daudé wrote:
>
> > The PPCTimebase structure is only used by the sPAPR machine.
> > Move its declaration to "hw/ppc/spapr.h".
> > Move vmstate_ppc_timebase and the VMSTATE_PPC_TIMEBASE_V()
> > macro to hw/ppc/spapr.c, along with the timebase_foo()
> > migration helpers.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   include/hw/ppc/spapr.h |   6 +++
> >   target/ppc/cpu-qom.h   |  22 --------
> >   hw/ppc/ppc.c           | 107 -------------------------------------
> >   hw/ppc/spapr.c         | 116 +++++++++++++++++++++++++++++++++++++++++
> >   4 files changed, 122 insertions(+), 129 deletions(-)


> I saw this series when it was original posted, but I failed to spot that 
> it didn't apply to the PPC Mac machines. I have a feeling this should 
> solve a long-running issue I've been having with decrementer migration, 
> in which case can it be moved (or left) somewhere where this is still 
> possible?

I'm not sure I understand what you ask. Do you want this code to
still be available for non-sPAPR machines? If so, I could move the
declarations to target/ppc/internal.h.