Re: [PATCH v4 04/19] vl: move display early init before default devices

[Marc-André Lureau]

Hi

On Wed, Oct 18, 2023 at 5:38 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The next commit needs to have the display registered itself before
> creating the default VCs.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

nack,

this needs further early display initialization from
qemu_create_default_devices(), will fix in v5

> ---
>  system/vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/system/vl.c b/system/vl.c
> index 3100ac01ed..73e4ed2bef 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -1933,7 +1933,6 @@ static void qemu_create_early_backends(void)
>                       "ignoring option");
>      }
>
> -    qemu_display_early_init(&dpy);
>      qemu_console_early_init();
>
>      if (dpy.has_gl && dpy.gl != DISPLAYGL_MODE_OFF && display_opengl == 0) {
> @@ -3664,6 +3663,7 @@ void qemu_init(int argc, char **argv)
>      suspend_mux_open();
>
>      qemu_disable_default_devices();
> +    qemu_display_early_init(&dpy);
>      qemu_create_default_devices();
>      qemu_create_early_backends();
>
> --
> 2.41.0
>