Re: [PATCH v5 03/19] ui: add pixman-compat.h

[Thomas Huth]

On 23/10/2023 13.30, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> This is a tiny subset of PIXMAN API that is used pervasively in QEMU
> codebase to manage images and identify the underlying format.
>
> It doesn't seems worth to wrap this in a QEMU-specific API.

IMHO it's not very beautiful, but after thinking about it for a while, I 
think it's acceptable and likely still better than disabling all the 
dependend devices...

> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   include/ui/pixman-compat.h | 195 +++++++++++++++++++++++++++++++++++++

Just a matter of taste, but I think I'd rather name it "pixman-minimal.h" 
instead.

Anyway:
Acked-by: Thomas Huth <thuth@redhat.com>