qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic
Date: Mon, 6 Nov 2023 08:17:45 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1

On 20/10/23 09:14, Zhao Liu wrote:
Hi Philippe,

On Fri, Oct 13, 2023 at 04:01:01PM +0200, Philippe Mathieu-Daudé wrote:
Date: Fri, 13 Oct 2023 16:01:01 +0200
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Subject: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic
X-Mailer: git-send-email 2.41.0

"target/foo/cpu-qom.h" is supposed to be target agnostic
(include-able by any target). Add such mention in the
header.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/arm/cpu-qom.h        | 2 +-
  target/hppa/cpu-qom.h       | 2 +-
  target/microblaze/cpu-qom.h | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

Why not mention this description for other qom-cpu.h in this series,
e.g., target/i386/cpu-qom.h.

OK, will add a comment in each patch.

Otherwise,

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]