qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 2/3] hw/ppc: Add emulation of AmigaOne XE board


From: BALATON Zoltan
Subject: Re: [PATCH v8 2/3] hw/ppc: Add emulation of AmigaOne XE board
Date: Tue, 7 Nov 2023 19:28:43 +0100 (CET)

On Tue, 7 Nov 2023, Peter Maydell wrote:
On Tue, 7 Nov 2023 at 18:21, BALATON Zoltan <balaton@eik.bme.hu> wrote:

The AmigaOne is a rebranded MAI Teron board that uses U-Boot firmware
with patches to support AmigaOS and is very similar to pegasos2 so can
be easily emulated sharing most code with pegasos2. The reason to
emulate it is that AmigaOS comes in different versions for AmigaOne
and PegasosII which only have drivers for one machine and firmware so
these only run on the specific machine. Adding this board allows
another AmigaOS version to be used reusing already existing peagasos2
emulation. (The AmigaOne was the first of these boards so likely most
widespread which then inspired Pegasos that was later replaced with
PegasosII due to problems with Articia S, so these have a lot of
similarity. Pegasos mainly ran MorphOS while the PegasosII version of
AmigaOS was added later and therefore less common than the AmigaOne
version.)
+    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, fwname);
+    if (!filename) {
+        error_report("Could not find firmware '%s'", fwname);
+        /* qtest/test-hmp expects to be able to run the machine without -bios 
*/
+        if (!qtest_enabled()) {
+            exit(1);
+        }

You should put the error_report() line inside the if() as well,
to stop the error line turning up in the logfiles/stdout. This
is what we do for the various MIPS boards that ordinarily
need a BIOS blob.

OK, I'll do a v9 then...

Regards,
BALATON Zoltan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]