Re: [PATCH v3 0/8] Add powernv10 I2C devices and tests

[Cédric Le Goater]

Nick,

On 11/14/23 20:56, Glenn Miles wrote:
> This series of patches includes support, tests and fixes for
> adding PCA9552 and PCA9554 I2C devices to the powernv10 chip.
>
> The PCA9552 device is used for PCIe slot hotplug power control
> and monitoring, while the PCA9554 device is used for presence
> detection of IBM CableCard devices.  Both devices are required
> by the Power Hypervisor Firmware on Power10 platforms.
>
> Changes from previous version:
>    - Added Fixes: tag to commits 3 and 4

Are you preparing a QEMU 8.2 PR for fixes ?

Thanks,

C.



>    - Fixed formatting errors in commits 2 and 8
>
> Glenn Miles (8):
>    ppc/pnv: Add pca9552 to powernv10 for PCIe hotplug power control
>    ppc/pnv: Wire up pca9552 GPIO pins for PCIe hotplug power control
>    ppc/pnv: PNV I2C engines assigned incorrect XSCOM addresses
>    ppc/pnv: Fix PNV I2C invalid status after reset
>    ppc/pnv: Use resettable interface to reset child I2C buses
>    misc: Add a pca9554 GPIO device model
>    ppc/pnv: Add a pca9554 I2C device to powernv10
>    ppc/pnv: Test pnv i2c master and connected devices
>
>   MAINTAINERS                     |   2 +
>   hw/misc/Kconfig                 |   4 +
>   hw/misc/meson.build             |   1 +
>   hw/misc/pca9554.c               | 328 ++++++++++++++++
>   hw/ppc/Kconfig                  |   2 +
>   hw/ppc/pnv.c                    |  35 +-
>   hw/ppc/pnv_i2c.c                |  47 ++-
>   include/hw/misc/pca9554.h       |  36 ++
>   include/hw/misc/pca9554_regs.h  |  19 +
>   tests/qtest/meson.build         |   1 +
>   tests/qtest/pnv-host-i2c-test.c | 650 ++++++++++++++++++++++++++++++++
>   11 files changed, 1103 insertions(+), 22 deletions(-)
>   create mode 100644 hw/misc/pca9554.c
>   create mode 100644 include/hw/misc/pca9554.h
>   create mode 100644 include/hw/misc/pca9554_regs.h
>   create mode 100644 tests/qtest/pnv-host-i2c-test.c