qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/ppc/Kconfig: Imply VFIO_PCI


From: Cédric Le Goater
Subject: Re: [PATCH] hw/ppc/Kconfig: Imply VFIO_PCI
Date: Fri, 24 Nov 2023 13:32:32 +0100
User-agent: Mozilla Thunderbird

On 11/24/23 11:10, Philippe Mathieu-Daudé wrote:
On 24/11/23 09:06, Cédric Le Goater wrote:
When the legacy and iommufd backends were introduced, a set of common
vfio-pci routines were exported in pci.c for both backends to use :

   vfio_pci_pre_reset
   vfio_pci_get_pci_hot_reset_info
   vfio_pci_host_match
   vfio_pci_post_reset

This introduced a build failure on PPC when --without-default-devices
is use because VFIO is always selected in ppc/Kconfig but VFIO_PCI is
not.

Use an 'imply VFIO_PCI' in ppc/Kconfig and bypass compilation of the
VFIO EEH hooks routines defined in hw/ppc/spapr_pci_vfio.c with
CONFIG_VFIO_PCI.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
  hw/ppc/spapr_pci_vfio.c | 36 ++++++++++++++++++++++++++++++++++++
  hw/ppc/Kconfig          |  2 +-
  2 files changed, 37 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks for reworking it without adding more stubs :)

yeah. no problem. It is simpler that way.

Thanks,

C.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]