|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 3/4] hw/pci-host/bonito: Access memory regions via pci_address_space[_io]() |
Date: | Tue, 6 Feb 2024 16:45:13 +0100 |
User-agent: | Mozilla Thunderbird |
Hi Bernhard, On 16/10/23 09:04, Philippe Mathieu-Daudé wrote:
On 16/10/23 00:19, Bernhard Beschow wrote:Am 11. Oktober 2023 18:59:53 UTC schrieb "Philippe Mathieu-Daudé" <philmd@linaro.org>:PCI functions are plugged on a PCI bus. They can only access external memory regions via the bus. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/pci-host/bonito.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)@@ -719,7 +719,7 @@ static void bonito_pci_realize(PCIDevice *dev, Error **errp)memory_region_init_alias(pcimem_alias, NULL, "pci.mem.alias", &bs->pci_mem, 0, BONITO_PCIHI_SIZE); - memory_region_add_subregion(get_system_memory(), + memory_region_add_subregion(pci_address_space(dev),I need to keep `get_system_memory()` here to get the same results for `info mtree` in the QEMU console before and after this patch when running `qemu-system-mips64el -M fuloong2e -S`. The other two changes above seem to work as expected.
Can I use add R-b tag after dropping this change?
[Prev in Thread] | Current Thread | [Next in Thread] |