Re: [PATCH v2] target/ppc: Move add and subf type fixed-point arithmetic instructions to decodetree

[Richard Henderson]

On 2/13/24 23:40, Chinmay Rath wrote:
> This patch moves the below instructions to decodetree specification:
>
>          {add, subf}[c,e,me,ze][o][.]       : XO-form
>          addic[.], subfic                   : D-form
>          addex                              : Z23-form
>
> This patch introduces XO form instructions into decode tree specification, for
> which all the four variations([o][.]) have been handled with a single pattern.
> The changes were verified by validating that the tcg ops generated by those
> instructions remain the same, which were captured with the '-d in_asm,op' flag.
>
> Signed-off-by: Chinmay Rath<rathc@linux.ibm.com>
> ---
> Changes v1 -> v2 :
> Reused X format for ADDEX instead of creating a new Z23_tab_cy
> format. (Richard)
> Added necessary instruction flag checks for ADDEX. (self-review)
> ---
>   target/ppc/insn32.decode                   |  26 ++++
>   target/ppc/translate.c                     | 136 ---------------------
>   target/ppc/translate/fixedpoint-impl.c.inc |  70 +++++++++++
>   3 files changed, 96 insertions(+), 136 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~