[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 17/56] hw/isa: fix ISA_SUPERIO dependencies
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 17/56] hw/isa: fix ISA_SUPERIO dependencies |
Date: |
Thu, 15 Feb 2024 18:57:11 +0100 |
From: Paolo Bonzini <pbonzini@redhat.com>
ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol:
instead it requires one. Among its users, VT82C686 is the only one that
is a PCI-ISA bridge and does not already select ISA_BUS.
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20240213155005.109954-5-pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/isa/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 7884179d08..5df3c09cd5 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -15,7 +15,7 @@ config I82378
config ISA_SUPERIO
bool
- select ISA_BUS
+ depends on ISA_BUS
select PCKBD
select PARALLEL
select SERIAL_ISA
@@ -47,6 +47,7 @@ config PIIX
config VT82C686
bool
+ select ISA_BUS
select ISA_SUPERIO
select ACPI
select ACPI_SMBUS
--
2.41.0
- [PULL 06/56] target/mips: Remove MIPSITUState::itu field, (continued)
- [PULL 06/56] target/mips: Remove MIPSITUState::itu field, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 07/56] target/mips: Remove CPUMIPSState::saarp field, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 08/56] hw/misc/mips_itu: Remove MIPSITUState::cpu0 field, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 09/56] hw/misc/mips_itu: Remove MIPSITUState::saar field, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 10/56] target/mips: Remove unused mips_def_t::SAARP field, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 11/56] target/mips: Remove CPUMIPSState::CP0_SAAR[2] field, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 12/56] target/mips: Remove helpers accessing SAARI register, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 13/56] target/mips: Remove CPUMIPSState::CP0_SAARI field, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 14/56] target/mips: Remove the unused DisasContext::saar field, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 15/56] hw/isa: clean up Kconfig selections for ISA_SUPERIO, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 17/56] hw/isa: fix ISA_SUPERIO dependencies,
Philippe Mathieu-Daudé <=
- [PULL 16/56] hw/mips/Kconfig: Remove ISA dependencies from MIPSsim board, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 18/56] hw/isa: specify instance_size in isa_superio_type_info, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 19/56] hw/isa: extract FDC37M81X to a separate file, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 20/56] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h', Philippe Mathieu-Daudé, 2024/02/15
- [PULL 21/56] hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 22/56] hw/i386/q35: Realize LPC PCI function before accessing it, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 23/56] hw/ppc/prep: Realize ISA bridge before accessing it, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 24/56] hw/misc/macio: Realize IDE controller before accessing it, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 25/56] hw/sh4/r2d: Realize IDE controller before accessing it, Philippe Mathieu-Daudé, 2024/02/15
- [PULL 26/56] hw/dma: Pass parent object to i8257_dma_init(), Philippe Mathieu-Daudé, 2024/02/15