Re: [PATCH v3 00/29] hw, target: Prefer fast cpu_env() over slower CPU QOM cast macro

[Thomas Huth]

On 29/01/2024 17.44, Philippe Mathieu-Daudé wrote:
> Patches missing review: 1, 2, 5, 6, 8, 11, 14, 15, 29
>
> It will be simpler if I get the whole series via my hw-cpus
> tree once fully reviewed.
>
> Since v2:
> - Rebased
> - bsd/linux-user
> - Preliminary clean cpu_reset_hold
> - Add R-b
>
> Since v1:
> - Avoid CPU() cast (Paolo)
> - Split per targets (Thomas)
>
> Use cpu_env() -- which is fast path -- when possible.
> Bulk conversion using Coccinelle spatch (script included).
>
> Philippe Mathieu-Daudé (29):
>    bulk: Access existing variables initialized to &S->F when available
>    hw/core: Declare CPUArchId::cpu as CPUState instead of Object
>    hw/acpi/cpu: Use CPUState typedef
>    bulk: Call in place single use cpu_env()
>    scripts/coccinelle: Add cpu_env.cocci script
>    target: Replace CPU_GET_CLASS(cpu -> obj) in cpu_reset_hold() handler
>    target/alpha: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/arm: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/avr: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/cris: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/hexagon: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/hppa: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/i386/hvf: Use CPUState typedef
>    target/i386: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/loongarch: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/m68k: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/microblaze: Prefer fast cpu_env() over slower CPU QOM cast
>      macro
>    target/mips: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/nios2: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/openrisc: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/ppc: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/riscv: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/rx: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/s390x: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/sh4: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/sparc: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/tricore: Prefer fast cpu_env() over slower CPU QOM cast macro
>    target/xtensa: Prefer fast cpu_env() over slower CPU QOM cast macro
>    user: Prefer fast cpu_env() over slower CPU QOM cast macro

FYI, I'll try to queue those for my PR today except for:

 scripts/coccinelle: Add cpu_env.cocci script
 --> Still needs review and you mentioned a pending change

 target/arm: Prefer fast cpu_env() over slower CPU QOM cast macro
 --> Needs a rebase and review

 target/hppa: Prefer fast cpu_env() over slower CPU QOM cast macro
 --> Needs a rebase

 target/i386: Prefer fast cpu_env() over slower CPU QOM cast macro
 --> There were unaddressed review comments from Igor

 target/riscv: Prefer fast cpu_env() over slower CPU QOM cast macro
 --> Needs a rebase

 Thomas