[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE de
|
From: |
Zhao Liu |
|
Subject: |
Re: [PATCH 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition |
|
Date: |
Tue, 12 Mar 2024 23:21:04 +0800 |
On Tue, Mar 12, 2024 at 03:13:40PM +0100, Markus Armbruster wrote:
> Date: Tue, 12 Mar 2024 15:13:40 +0100
> From: Markus Armbruster <armbru@redhat.com>
> Subject: [PATCH 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE
> definition
>
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Address the comment added in commit 4629ed1e98
> ("qerror: Finally unused, clean up"), from 2015:
>
> /*
> * These macros will go away, please don't use
> * in new code, and do not add new ones!
> */
>
> Manual changes (escaping the format in qapi/visit.py).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qapi/qmp/qerror.h | 3 ---
> qom/object.c | 4 ++--
> scripts/qapi/visit.py | 5 ++---
> 3 files changed, 4 insertions(+), 8 deletions(-)
>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
- [PATCH 00/10] Reduce usage of QERR_ macros further, Markus Armbruster, 2024/03/12
- [PATCH 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition, Markus Armbruster, 2024/03/12
- Re: [PATCH 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition,
Zhao Liu <=
- [PATCH 10/10] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition, Markus Armbruster, 2024/03/12
- [PATCH 04/10] qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG definition, Markus Armbruster, 2024/03/12
- [PATCH 05/10] qapi: Inline and remove QERR_INVALID_PARAMETER definition, Markus Armbruster, 2024/03/12
- [PATCH 06/10] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value), Markus Armbruster, 2024/03/12
- [PATCH 08/10] qapi: Correct error message for 'vcpu_dirty_limit' parameter, Markus Armbruster, 2024/03/12