[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 18/23] hw/openrisc/cputimer: Emit warning when old cod
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC PATCH v2 18/23] hw/openrisc/cputimer: Emit warning when old code is used |
Date: |
Sat, 4 Jul 2020 17:47:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/4/20 5:39 PM, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/openrisc/cputimer.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c
> index 93268815d8..60f2c9667f 100644
> --- a/hw/openrisc/cputimer.c
> +++ b/hw/openrisc/cputimer.c
> @@ -22,6 +22,7 @@
> #include "cpu.h"
> #include "migration/vmstate.h"
> #include "qemu/timer.h"
> +#include "hw/qdev-deprecated.h"
>
> #define TIMER_PERIOD 50 /* 50 ns period for 20 MHz timer */
>
> @@ -135,6 +136,8 @@ static const VMStateDescription vmstate_or1k_timer = {
>
> void cpu_openrisc_clock_init(OpenRISCCPU *cpu)
> {
> + qdev_warn_deprecated_function_used();
Please disregard this patch, I forgot to address Paolo's comment:
https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg02202.html
> +
> cpu->env.timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, &openrisc_timer_cb,
> cpu);
> cpu->env.ttmr = 0x00000000;
>
>
- [RFC PATCH v2 10/23] hw/display/vga-isa-mm: Emit warning when old code is used, (continued)
- [RFC PATCH v2 10/23] hw/display/vga-isa-mm: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 11/23] hw/dma/etraxfs_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 13/23] hw/input/lasips2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 12/23] hw/dma/soc_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 14/23] hw/input/tsc2005: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 15/23] hw/m68k/mcf520x: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 16/23] hw/misc/cbus: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 17/23] hw/nvram/eeprom93xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 18/23] hw/openrisc/cputimer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- Re: [RFC PATCH v2 18/23] hw/openrisc/cputimer: Emit warning when old code is used,
Philippe Mathieu-Daudé <=
- [RFC PATCH v2 19/23] hw/ppc/ppc4xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 20/23] hw/sh4: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 21/23] hw/riscv: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 22/23] hw/usb/hcd-musb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 23/23] hw/xtensa/xtfpga: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04