Re: [PATCH 3/5] [RISCV_PM] Print new PM CSRs in QEMU logs

[Alexey Baturo]

First of all thank you so much for reviewing these patches!

>RVJ.

Thanks, I missed this typo, will fix it.

>Probably you only want to dump the set that's current.

I don't know for sure how anyone would be using this while debugging PM related code, but I like the idea, so I'll try to do it, thanks!

ср, 14 окт. 2020 г. в 21:41, Richard Henderson <richard.henderson@linaro.org>:

On 10/14/20 10:01 AM, Alexey Baturo wrote:
> +    if (riscv_has_ext(env, RVH)) {

RVJ.

> +        qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "mmte    ", env->mmte);
> +        qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "upmbase ", env->upmbase);
> +        qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "spmbase ", env->spmbase);
> +        qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "mpmbase ", env->mpmbase);
> +        qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "upmmask ", env->upmmask);
> +        qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "spmmask ", env->spmmask);
> +        qemu_fprintf(f, " %s " TARGET_FMT_lx "\n", "mpmmask ", env->mpmmask);

Probably you only want to dump the set that's current.


r~